Squaremap Support #107
Merged
Squaremap Support #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/io/github/townyadvanced/townyprovinces/TownyProvinces.java
LlmDl
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #44
Adds SquareMap support
This has been tested against:
1.20.4 Paper (with, and without map plugin)
1.20.4 Spigot (with, and without map plugin)
1.16.5 Paper (without mappers - no support for 1.16.5)
1.16.5 Spigot (without mappers - as above)
1.18.1 Paper (with, and without map plugin - this is the lowest version supported by SquareMap, using an old version)
PR has passed all of my extensive testing with no exceptions thrown or unintended results (results are recorded in a thread in TownyProvinces channel on Towny Discord for this)
Additionally this updates the Pl3xMap dependency to 1.20.4 in pom.xml - This requires no other changes, compiles the same and was done purely as the version there is no longer available. - I didn't think this was worth such a tiny PR on its own as this was being done also.